feat(content-type): add warning if a pac file is found but the content-type is invalid #79
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t-type is invalid
…ing_for_invalid_content_type
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First thanks for this project. This is really useful to be able to deal with the mess of proxy management.
We are using pypac in one of our project related to QGIS profile deployment : https://github.com/qgis-deployment/qgis-deployment-toolbelt-cli
This was working for one of our client but suddendly there was no more proxy indicated by pypac.
I did some debug and in fact it came from the fact that the content-type of the pac file changed changed. pypac didn't consider the pac file as valid because the content-type is now
text/plain.I would like pypac to indicate that a pac file was found but that the content-type is invalid.
I added a warning log.